On Tue, Feb 3, 2026 at 5:05 PM Mircea Cadariu <[email protected]> wrote: > I've picked up the review for your patch.
Thanks for picking it! > Attached is a failing test that reproduces the issue. Have I got it > right? We can consider using it to validate your patch then. Yeah, that's the gist of it. However, the test you've written will only work on little endian architectures. Also, I think the xlog page header size won't have the 4 bytes padding on 32 bits systems. I've added a similar test in 001_basic.pl, but it relies on copying an existing WAL file and setting the WAL magic to 0000. This way, the result will be the same independent of the endianness and memory padding. Regards, Anthonin Bonnefoy
v2-0001-Propage-errormsg-to-XLogFindNextRecord-caller.patch
Description: Binary data
