On Fri, Sep 14, 2018 at 12:35:54PM -0300, Alvaro Herrera wrote: > On 2018-Sep-13, Michael Paquier wrote: >> Improve autovacuum logging for aggressive and anti-wraparound runs >> >> A log message was being generated when log_min_duration is reached for >> autovacuum on a given relation to indicate if it was an aggressive run, >> and missed the point of mentioning if it is doing an anti-wrapround >> run. The log message generated is improved so as one, both or no extra >> details are added depending on the option set. > > Hmm, can a for-wraparound vacuum really not be aggressive? I think one > of those four cases is really dead code.
Sure, at the same time it is a no-brainer to keep the code as is, and seeing log messages where (!aggressive && wraparound) would be an indication of surrounding bugs, no? There have been issues in this area in the past. -- Michael
signature.asc
Description: PGP signature
