On Tuesday, February 10, 2026, shveta malik <[email protected]> wrote:

> >
> > The attached v42 version patch has the changes for the same.
> >
>
> Thanks, will review.
>

Publication names are unique within the database.  In
check_publications_except_list, the use of “select distinct” when pulling
from pg_publication by name is unnecessary.  Furthermore, if we only have a
single publication name it is unnecessary to perform the check and thus no
need to even run the query.

David J.


+check_publications_except_list(WalReceiverConn *wrconn, List *publications)
+{
+ WalRcvExecResult *res;
+ StringInfoData cmd;
+ TupleTableSlot *slot;
+ Oid tableRow[1] = {TEXTOID};
+ List   *except_publications = NIL;
+
+ initStringInfo(&cmd);
+ appendStringInfoString(&cmd,
+   "SELECT DISTINCT p.pubname\n"
+   "  FROM pg_catalog.pg_publication p\n"
+   " WHERE p.pubname IN (");
+
+ GetPublicationsStr(publications, &cmd, true);
+
+ appendStringInfoString(&cmd,
+   ")\n"
+   "   AND EXISTS (SELECT 1\n"
+   "                 FROM pg_catalog.pg_publication_rel pr\n"
+   "                WHERE pr.prpubid = p.oid\n"
+   "                  AND pr.prexcept IS TRUE)");

Reply via email to