On Wed, Feb 18, 2026 at 12:28 PM shveta malik <[email protected]> wrote:
>
> On Wed, Feb 18, 2026 at 11:41 AM Amit Kapila <[email protected]> wrote:
> >
> > On Tue, Feb 17, 2026 at 5:08 PM shveta malik <[email protected]> wrote:
> > >
> > > A few more:
> > >
> > > 6)
> > > postgres=# CREATE PUBLICATION pub4 for ALL TABLES  EXCEPT TABLE (tab1);
> > > ERROR:  cannot add relation "tab1" to publication
> > > DETAIL:  This operation is not supported for temporary tables.
> > >
> > > postgres=# CREATE PUBLICATION pub4 for ALL TABLES  EXCEPT TABLE (tab2);
> > > ERROR:  cannot add relation "tab2" to publication
> > > DETAIL:  This operation is not supported for unlogged tables.
> > >
> > > Shall we change the error message here as we are not trying to add
> > > relation here.
> > >
> >
> > But aren't these existing messages? As these are not added by this
> > patch and equally apply to existing code, so, isn't it better to
> > discuss these separately if you think these are not suitable?
> >
>
>  I do not have strong opinion here but this is what I originally had in mind:
>
> 1) 'cannot add relation .. to publication' is confusing when the user
> is actually trying to exclude them.
> 2) Since these tables are already excluded because of their unlogged
> and temporary nature, the error is further misleading.
>
> Perhaps we shall have:
> ERROR:  cannot specify relation "tab1" in publication
> DETAIL:  Unlogged tables are automatically excluded from publication.
>

Your proposed message for this case sounds good to me.

-- 
With Regards,
Amit Kapila.


Reply via email to