Hi Daniel, Thank you for the review. All the changes suggested in the v52comments.diff are incorporated in the attached patches.
+#Server should have thrown error > +$node->psql( > + 'postgres', > + qq(select pg_get_process_memory_contexts($pid, true);), > + stderr => \$psql_err); > > This test doesn't validate that the server actually errored does it? > (There is > no proposed fix in the attached.) > > This has been fixed by adding a check for the error returned by the above command. While at it, I also added another crash test to the file, This is similar to the existing test for a client backend crash, but in this scenario, it crashes the server process instead. Thank you, Rahila Syed
v53-0001-Add-function-to-report-memory-context-statistics.patch
Description: Binary data
v53-0002-Test-module-to-test-memory-context-reporting-wit.patch
Description: Binary data
