On 2026-Feb-24, David Geier wrote: > This has changed over the years. On master there are only 5 calls to > array_ref() and 5 calls to array_set() left. Are there any objections > against cleaning up the code by removing array_ref() and array_set()?
I think it would be kinda silly to oppose the removal of use of an essentially deprecated API for no reason; however, those functions are used by the GUC machinery directly as exported functions (because the functions operate on arrays as ArrayType), so if you wanted to change that, you'd incur in an API break. So that case is different: would you want to impose a change on third-party authors that are using these functions? For me the answer would be, if we gain something, and the change is easy for them to make, then sure, let's change it. If we don't gain anything, then ... why break things for them? First example I found on codesearch.debian.net is: https://sources.debian.org/src/credcheck/4.6-1/credcheck.c?hl=2811#L2811 Maybe it's not a big deal, but that's an assessment that I think should be made. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ "No es bueno caminar con un hombre muerto"
