On Wed, Feb 25, 2026, at 8:53 AM, Álvaro Herrera wrote: > > I'm surprised to not have seen an update on this topic following the > discovery by Mark Wong that commit d32d1463995c (in branch 18) already > established a convention for passing arguments to functions: use argument > pairs to variadic functions, the way pg_restore_relation_stats() and > pg_restore_attribute_stats() work. While I like my previous suggestion > of using DefElems better, I think it's more sensible to follow this > established precedent and not innovate on this. >
This convention is much older than the referred commit. It predates from the logical decoding (commit b89e151054a0). See pg_logical_slot_get_changes_guts() that is an internal function for pg_logical_slot_FOO_changes(). It seems a good idea to have a central function to validate the variadic parameter for all of these functions. -- Euler Taveira EDB https://www.enterprisedb.com/
