> On 11 Jan 2026, at 16:32, Kirill Reshke <[email protected]> wrote: > > PFA v2 Nice feature, it would be good to have in. Some nits: 1. File header is wrong — says "gistfuncs.c" and "GiST" 2. Traces of GiST are everywhere, in function names, in error messages, etc 3. spgist_metapage_items — wrong errdetail for magic number check ("Expected special size") 4. "values[6] = InvalidTransactionId;" more conventional would be "TransactionIdGetDatum(InvalidTransactionId)" 5. spgist_innerpage_items — has_datums used uninitialized in SPGIST_DEAD+ cases 6. spgist_innerpage_items — doesn't output prefix/node data, is it by design? 7. you use index_deform_tuple_internal() instead of spgDeformLeafTuple(), I'm not sure that's conventional also 8. "values[2] = UInt32GetDatum(leafTuple->size);" must be "values[2] = UInt16GetDatum(leafTuple->size);" according to "OUT size smallint,"? 9. "OUT blkno smallint," also raises sizing questions Thanks for working on this! Best regards, Andrey Borodin.
