On Fri, Feb 27, 2026 at 08:15:22AM +0900, Michael Paquier wrote: > Let's just remove this flag. I would have let XLP_ALL_FLAGS as it is > now at 0x000F, though. It is just used for filtering the bits we > allow to exist in this area of the header, for validation. Perhaps > some forks like this extensibility if they have their own extra custom > bits, meaning less code to modify. That's a minor point for sure, but > people like hacking on Postgres and forking this code.
Done. The patch missed a variable declaration not required anymore in AdvanceXLInsertBuffer(), that I have caught with a compiler warning. Another thing that did not feel right was to mark 0x0004 as free, so I have moved the contrecord value one level down and updated XLP_ALL_FLAGS accordingly, like ff9f111bce24 and 2dd9322ba6ee. XLOG_PAGE_MAGIC also got its bump. -- Michael
signature.asc
Description: PGP signature
