Here's a small updated version of the patch, with the 2 different approaches.
- 0001: This is the XLogSetAsyncXactLSN call in RecordTransactionAbort
approach. The small difference with v3 is that the 'XactLastRecEnd !=
0' condition is now merged with !isSubXact:
+if (!isSubXact && XactLastRecEnd != 0)
+{
+ XLogSetAsyncXactLSN(XactLastRecEnd);
XactLastRecEnd = 0;
+}
- 0002: This is the ShutdownXLOG approach. I've used
XLogFlush(WriteRqstPtr) instead of updating the async LSN. It feels
like if we're going to stop the walsenders, we may as well flush
everything and get the WAL in a good state.
The spinlock to access XLogCtl->LogwrtRqst.Write is probably
unnecessary since we're at a point where no additional WAL records
should be written, but it doesn't hurt to keep consistency.
Regards,
Anthonin Bonnefoy
v4-0002-Fix-stuck-shutdown-due-to-unflushed-records.patch
Description: Binary data
v4-0001-Fix-stuck-shutdown-due-to-unflushed-records.patch
Description: Binary data
