On Tue, 03 Mar 2026 at 14:08, Andrey Silitskiy <[email protected]> wrote: > On Feb 10, 2026 Ronan Dunklau <ronan(at)dunklau(dot)fr> wrote: >> - however, if one were to stop the service before doing a pg_upgrade, >> they would have no other choice than either disable the behaviour >> entirely (by switching to wait_flush) or fail the upgrade if a logical >> replication slot is pending changes. > > I agree with you, this idea is more flexible. So I changed the interface > from the one discussed in this thread from the very beginning to a timeout. > Propose an updated patch. > > Best Regards, > Andrey >
At first glance, wal_sender_shutdown_timeout seems to have the wrong type. It should be an integer, not an enum. + <term><varname>wal_sender_shutdown_timeout</varname> (<type>enum</type>) > [2. text/x-patch; > v1-0001-Introduce-a-new-GUC-wal_sender_shutdown_timeout.patch]... -- Regards, Japin Li ChengDu WenWu Information Technology Co., Ltd.
