On 2026-03-03 Tu 6:17 AM, Mahendra Singh Thalor wrote:
On Tue, 3 Mar 2026 at 14:55, Peter Eisentraut <[email protected]> wrote:
I noticed this cast in the committed code:
+ num_total_db = get_dbname_oid_list_from_mfile((char *) inputFileSpec,
&dbname_oid_list);
The cast drops the const qualifier from inputFileSpec.
get_dbname_oid_list_from_mfile() writes into the space pointed to by its
argument, so it's really not "const". (And inputFileSpec points into
argv, so this ends up writing directly into argv.)
Please see if you can clean this up. It might be best if
get_dbname_oid_list_from_mfile() made a copy of its argument that it can
write into, and then the argument can be "const".
Thanks Peter.
Here, I am attaching a patch to fix this issue.
Pushed with a slight tweak.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
