On Fri, 6 Mar 2026 at 16:51, Nisha Moond <[email protected]> wrote: > > On Fri, Mar 6, 2026 at 1:47 PM vignesh C <[email protected]> wrote: > > > > Thanks for the comments, the attached v58 version patch has the > > changes for the same. > > > > Thanks for the patches. I reviewed and tested v58-0001, and here are a > few comments: > > 1) alter_publication.sgml > +<phrase>where <replaceable > class="parameter">publication_set_object</replaceable> is one > of:</phrase> > + > + EXCEPT TABLE [ ONLY ] ( <replaceable > class="parameter">table_name</replaceable> [, ... ] ) > > Should ONLY be moved inside parentheses(), as it applies per table:- > EXCEPT TABLE ( [ ONLY ] table_name [, ...] )
Modified > 2) publicationcmds.c > postgres=# alter publication pub2 set EXCEPT TABLE (t3); > ERROR: publication "pub2" is not defined as FOR ALL TABLES > DETAIL: EXCEPT Tables cannot be added to publications that are not > defined as FOR ALL TABLES. > > The DETAIL message “EXCEPT Tables cannot be added …” could be adjusted , e.g., > EXCEPT tables cannot be added ... > or > EXCEPT TABLE cannot be used for publications ... I felt the current message is in line with the existing messages in that function. So not making any change. > 3) gram.y > The comments above "AlterPublicationStmt:" should be updated for the > newly supported command. Updated The v59 version patch attached at [1] has the changes for the same. [1] - https://www.postgresql.org/message-id/CALDaNm34tpJDVxEr70dmggY6sWyJxvaSuHN%2BpW2B6skTtjs46A%40mail.gmail.com Regards, Vignesh
