On Mon, Mar 9, 2026 at 8:22 AM vignesh C <[email protected]> wrote:
>
> The attached v59 patch has the changes to update the syntax accordingly.
>
Thanks for the patch, here are few comments:
1) commit message:
"... the user must first modify
the publication using ALTER PUBLICATION ... SET EXCEPT TABLE
before attaching the partition."
The command is modified now and "SET EXCEPT TABLE" is no longer
supported, so it should be -
"... the user must first modify
the publication using ALTER PUBLICATION ... SET ALL TABLES EXCEPT TABLE
before attaching the partition."
~~~
2) Unexpected behavior: "ALTER PUBLICATION pub1 SET ALL TABLES;"
succeeds for a non-ALL TABLES publication and removes the existing
tables from the publication:
CREATE publication pub1 for table t1;
postgres=# \dRp+
Publication pub1
Owner | All tables | All sequences | Inserts | Updates | Deletes |
Truncates | Generated columns | Via root | Description
---------+------------+---------------+---------+---------+---------+-----------+-------------------+----------+-------------
moond_n | f | f | t | t | t |
t | none | f |
Tables:
"public.t1"
postgres=# alter publication pub1 set all tables ;
ALTER PUBLICATION
postgres=# \dRp+
Publication pub1
Owner | All tables | All sequences | Inserts | Updates | Deletes |
Truncates | Generated columns | Via root | Description
---------+------------+---------------+---------+---------+---------+-----------+-------------------+----------+-------------
moond_n | f | f | t | t | t |
t | none | f |
(1 row)
3) Should we add a test for "ALTER PUBLICATION tab_pub SET ALL
TABLES;" verification?
--
Thanks,
Nisha
