Thanks for the updated patch! --- Since pg_stat_database stats_reset starts out as NULL, reset it once first so we have something to compare it to +-- Since stats_reset in pg_stat_database and pg_stat_database_conflicts starts +-- out as NULL, reset it once first so we have something to compare it to SELECT pg_stat_reset(); -SELECT stats_reset AS db_reset_ts FROM pg_stat_database WHERE datname = (SELECT current_database()) \gset +SELECT D.stats_reset AS db_reset_ts, DC.stats_reset AS dbc_reset_ts +FROM pg_stat_database D, pg_stat_database_conflicts DC +WHERE D.datname = (SELECT current_database()) AND D.datname = DC.datname \gset SELECT pg_stat_reset(); -SELECT stats_reset > :'db_reset_ts'::timestamptz FROM pg_stat_database WHERE datname = (SELECT current_database()); +SELECT D.stats_reset > :'db_reset_ts'::timestamptz, + DC.stats_reset > :'dbc_reset_ts'::timestamptz, + D.stats_reset = DC.stats_reset +FROM pg_stat_database D, pg_stat_database_conflicts DC +WHERE D.datname = (SELECT current_database()) AND D.datname = DC.datname;
I think the changes to the test are overcomplicated unnecessarly. We should not have to join pg_stat_database and pg_stat_database_conflicts. We can just query each fo the stats_reset separately. see v5, I kept the check to ensure that pg_stat_database and pg_stat_database_conflicts have the same reset time. I think this is good to have as well. I also updated the existing comment for more clarity. -- Sami Imseih Amazon Web Services (AWS)
v5-0001-Add-stats_reset-column-to-pg_stat_database_confli.patch
Description: Binary data
