On Fri, 13 Mar 2026 at 17:30, Andrew Dunstan <[email protected]> wrote: > > > On 2026-03-12 Th 11:55 PM, jian he wrote: > > Hi. > > > > The regression test was very verbose; I removed some of it. > > Also polished function ExecEvalJsonIsPredicate a little bit. > > > > Here's a v4. I changed resultBaseType to exprBaseType - I think it's > clearer. I also trimmed the tests a bit more, and dropped the new > objects after testing them. The error message now shows the domain name > rather than the underlying base type. I think that's more useful. >
Hi! V4 looks good. The only thing that I cannot explain is removing the `exprtype` variable inside ExecEvalJsonIsPredicate. We can just change its declaration to exprtype = pred->exprBaseType if i'm not mistaken? Anyway, LGTM > -- > Andrew Dunstan > EDB: https://www.enterprisedb.com -- Best regards, Kirill Reshke
