>> It will be good to add more commentary here to the next person adding >> a test, and mention >> that only stable values should be included in this view. what do you think? > > > I added a comment, but I don't think a test writer would be confused for long > if they did break that rule.
Thanks! it looks like you added the additional comment to 0002 rather than 0001 which introduced the view. I fixed that in the attached. >> + (references <link >> linkend="catalog-pg-class"><structname>pg_statistic_ext</structname></link>.<structfield>stxrelid</structfield>) > > > Fixed catalog-pg-attribute and catalog-pg-statistic-ext A few references were missed in 0002. + <row> + <entry role="catalog_table_entry"><para role="column_definition"> + <structfield>expr_attnum</structfield> <type>int2</type> + </para> + <para> + Synthetic attnum used to reference this expression in + <link linkend="catalog-pg-class"><structname>pg_statistic_ext</structname></link>.<structfield>stxdndistinct</structfield> + and + <link linkend="catalog-pg-class"><structname>pg_statistic_ext</structname></link>.<structfield>stxddependencies</structfield> + </para></entry> + </row> Also fixed in v7 -- Sami Imseih Amazon Web Services (AWS)
v7-0001-Add-test-view-pg_stats_check.patch
Description: Binary data
v7-0002-Add-tableid-statid-attnum-expr_attnum-columns-to-.patch
Description: Binary data
v7-0003-pg_dump-Use-tableid-in-getAttributeStats.patch
Description: Binary data
