On Mon, Mar 16, 2026 at 3:47 AM Michael Paquier <[email protected]> wrote: > > On Fri, Mar 13, 2026 at 10:39:40AM +0530, Ashutosh Sharma wrote: > > Thanks for sharing your thoughts, Michael, I had a similar idea in > > mind. I'll go ahead and implement these changes and come up with the > > new patches. Now since this is purely additive (new columns only), I'm > > thinking a single patch might suffice, Or maybe, we could split it > > into two: one that corrects the existing documentation and another > > that introduces the new fields for displaying downstream bytes sent > > and some other information related to this. > > Thanks. We'd better move forward quickly with this one based on the > current calendar, still it would be good to hear from Ashutosh Bapat > and double-check with him.
I got busy with SQL/PGQ [1], resizable shared structures [2] and pgconf.india last week. Thanks Ashutosh Sharma for picking this up. Addition of _wal_ was suggested by Andres offlist [3]. That was long back and didn't have other opinions to validate the renaming. I see that there are more opinions against renaming now. There is also merit in not renaming it on the grounds that the users are used to the old names and will find new names confusing. Whether we do it now or later, it's going to break backward compatibility. Not renaming now has the advantage that we can avoid it all together if users do not find the names confusing in the context of the new column. Let's leave the renaming aside for now. I would post two patches 1. To introduce the new column sent_bytes + clarify total_bytes in the context of sent_bytes. We should consider this patch for committing. 2. Addition of filtered_bytes + sent_txns and also the clarification of total_bytes and total_txns in the context of the new columns. We will decide whether to commit the patch after 0001 is committed. [1] https://www.postgresql.org/message-id/CAExHW5ufB8y1oguSea_9WPFHFDOOTsxZ3Na_OAUBF-H%2BB7AfYw%40mail.gmail.com [2] https://www.postgresql.org/message-id/flat/CAExHW5vM1bneLYfg0wGeAa%3D52UiJ3z4vKd3AJ72X8Fw6k3KKrg%40mail.gmail.com [3] https://www.postgresql.org/message-id/CAExHW5vnRPp5dof35DEGdc8W2tS16E5CbmGey28Y=rj9qrp...@mail.gmail.com -- Best Wishes, Ashutosh Bapat
