Hi, On Mon, Mar 16, 2026 at 11:16:51AM +0000, Bertrand Drouvot wrote: > Hi, > > On Mon, Mar 16, 2026 at 11:42:35AM +0100, Peter Eisentraut wrote: > > On 24.02.26 12:28, Bertrand Drouvot wrote: > > > > You can/should use C11 standard alignas(), so you don't need to worry > > > > about > > > > whether it's supported or not. > > > > > > Oh right, I did not notice 300c8f53247 and following like e7075a3405c, > > > d4c0f91f7d5 > > > and 97e04c74bed. > > > > > > PFA, 0001 doing so for PGPROC and PgAioUringContext. As those are typedef, > > > the patch puts alignas within the struct. > > > > > > For PGPROC at the start of the struct, I think that placing it on the > > > first member > > > is the right location because it ensures the whole struct is aligned to > > > PG_CACHE_LINE_SIZE > > > without adding padding before this member. For example if I set it on > > > backendType, > > > then it adds 100 bytes of padding and the struct is obviously still a > > > multiple of > > > PG_CACHE_LINE_SIZE but is now 1024 bytes (instead of 896). > > > > > > For PgAioUringContext at completion_lock (like suggested by Andres in > > > [1]), which > > > is also the start of the struct. > > > > > > I checked and the padding for those are exactly the same after the > > > changes. > > > > I have committed the 0001 patch. > > Thanks! I don't know why but I don't see it in > https://git.postgresql.org/gitweb/?p=postgresql.git;a=summary, > or in the github repo though.
FWIW, I reached out to sysadmins@ and it has now been fixed. Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
