Hi Henson, >> Got it, thanks. By the way, how about splitting the test patch >> into two -- one for sql + data files and another for expected >> output files? The single test patch is getting quite large and >> cfbot often fails to apply it. > > Sounds like a good idea.
I have made an estimate how large each patch part is. SQL + data patches: src/test/regress/sql/rpr.sql | 1164 ++++ src/test/regress/sql/rpr_base.sql | 3986 +++++++++++++ src/test/regress/sql/rpr_explain.sql | 2296 ++++++++ src/test/regress/sql/rpr_nfa.sql | 3278 +++++++++++ src/test/regress/parallel_schedule | 5 + src/test/regress/data/stock.data | 1632 ----------------------------------------------------- total 12361 Expected patches: src/test/regress/expected/rpr.out | 2356 ++++++++ src/test/regress/expected/rpr_base.out | 6202 +++++++++++++++++++++ src/test/regress/expected/rpr_explain.out | 3968 +++++++++++++ src/test/regress/expected/rpr_nfa.out | 4340 ++++++++++++++ ----------------------------------------------------- total 16866 It seems we will have about 12k (sql and data) and 16k (expected) patches. Looks nice balance. Best regards, -- Tatsuo Ishii SRA OSS K.K. English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sraoss.co.jp
