On Tue, Mar 24, 2026 at 8:31 AM Aleksander Alekseev <[email protected]> wrote: > > Hi, > > > > The patch looks basically good to me. I've made some changes to the > > > regression test part as I want to have round-trip tests. I've merged > > > the tests checking the sortability to the existing tests and added > > > round-trip tests. With this change, we can test round-trip tests and > > > sortability tests with random UUID value in every test run while > > > minimizing the test time. Feedback is very welcome. > > v11 looks good to me. > > > It looks like leading, trailing, and embedded whitespace are all ignored. > > But I don’t see a test case covering this behavior, so maybe it would be > > good to add one. > > I intentionally didn't include this test because the code is trivial: > > `` > /* Skip whitespace */ > if (c == ' ' || c == '\t' || c == '\n' || c == '\r') > continue; > ``` > > And also because we never tested it for base64. If we want to start > testing it we should add tests both for base64 and base32hex which IMO > should be a separate patch.
Agreed. I've attached the updated version patch that includes the following points: - changed the order of encodings in the doc and the hint message to maintain alphabetical order. - changed the query example to extract data from the encoded UUID value to use rtrim() as it's more intuitive. - added some regression tests for decoding unpadded inputs. I'm going to push the patch unless there are comments on these changes. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
v12-0001-Add-base32hex-support-to-encode-and-decode-funct.patch
Description: Binary data
