> On Tue, Mar 24, 2026 at 01:32:40PM +1300, David Rowley wrote: > > +1 for main patch first. I do think a view would be useful as a > > follow-up. However, which columns we put in that view might have some > > influence on how the current patch should look. I think the view > > should show the individual scores and the total score as the Max() of > > the individual scores. If we didn't do that, it might be confusing to > > the user which aspect of the score the final score is derived from. > > That might mean that it'd be better to have > > relation_needs_vacanalyze() output the scores individually, or perhaps > > populate a struct that we pass in that gets allocated on the stack > > during do_autovacuum(). That'd mean a bit less churn if we go with the > > view containing individual scores. > > Agreed. Here's a first try at that. I also updated the DEBUG3 at the end > of relation_needs_vacanalyze() to show the individual scores. The comment > above that function might need some work, and we might need a bit of > additional commentary elsewhere.
This is good and these values could be exposed in the future view individually. I like this. v15 also LGTM. -- Sami
