> 1) I think "SetConstantLengths" should be renamed to > "GetConstantLengths", or "CalculateConstantLengths" in 0002, since > we're no longer modifying JumbleState
Makes sense. I renamed it to ComputeConstantLengths; as this will reflect that it's more than a getter function, and it's doing actual work. Compute also seems more consistent with other function names we have out there. > 2) I wonder if we should export this function in 0002 - that would > specifically help pg_tracing, which also wants to extract inline > parameter values in addition to replacing them with a $n parameter > reference marker - I could also see that being useful for any other > extension that's interested in pulling out parameter values > I've also done some testing with two previously mentioned extensions, > pg_stat_monitor [0] and pg_tracing [1]. Both look like they can be > adapted to the new method with their regression tests succeeding. That did cross my mind. I agree with this. Both of those changes belong in 0002. See the attached v7. -- Sami Imseih Amazon Web Services (AWS)
v7-0001-pg_stat_statements-Move-query-normalization-to-co.patch
Description: Binary data
v7-0002-Make-JumbleState-const-in-post_parse_analyze-hook.patch
Description: Binary data
