On 2026-03-28 Sa 10:30 AM, David E. Wheeler wrote:
On Mar 28, 2026, at 06:04, Andrew Dunstan <[email protected]> wrote:
I have fixed that. Some key_name entries were missing, which was an issue. I
also removed some unused variables and some duplicate tests, and did some
general tidying.
Looks good to me! I’m curious what the implication of missing `key_name`s was,
since the tests passed and all the functions worked. Can we create additional
tests that would fail when the keys were missing?
The key_name production is what allows a keyword to also be used as an
object key in $.keyname syntax. The trim keywords (ltrim, rtrim, btrim)
were added there, so $.ltrim as a key works. But $.lower,
$.upper, $.initcap, $.replace, and $.split_part as keys would all break.
There are tests added for it.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
