Andres Freund <and...@anarazel.de> writes: > On 2018-09-26 21:44:41 -0400, Tom Lane wrote: >> BTW, were you thinking of plugging in strfromd() inside snprintf.c, >> or just invoking it directly from float[48]out? The latter would >> presumably be cheaper, and it'd solve the most pressing performance >> problem, if not every problem.
> I wasn't actually seriously suggesting we should use strfromd, but I > guess one way to deal with this would be to add a wrapper routine that > could directly be called from float[48]out *and* from fmtfloat(). Yeah, something along that line occurred to me a bit later. > Wonder > if it'd be worthwhile to *not* pass that wrapper a format string, but > instead pass the sprecision as an explicit argument. Right, getting rid of the round trip to text for the precision seems like a win. I'm surprised that strfromd is defined the way it is and not with something like (double val, char fmtcode, int precision, ...) regards, tom lane