> On May 6, 2026, at 04:53, Zsolt Parragi <[email protected]> wrote: > > Hello > > - server = GetForeignServer(subform->subserver); > + server = GetForeignServer(sub->serverid); > > Couldn't we also move this inside the if?
Ah, true. Both aclresult and server can be moved into the if. > > +/* > + * Return the subscription's connection string, loading it into the > + * subscription memory context if necessary. > + * > + * GetSubscription must be called earlier to set sub->serverid, because ACL > + * checks are performed there. > + */ > +char * > +GetSubscriptionConnInfo(Subscription *sub) > > This is related to Ajin's comment earlier, the part about ACL check > seems incorrect to me. Yes, see my reply to Ajin in the previous email. PFA v3 - addressed Ajin and Zsolt’s comments. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/
v3-0001-Allow-altering-subscription-server-connection-wit.patch
Description: Binary data
