> On May 10, 2026, at 06:38, Álvaro Herrera <[email protected]> wrote: > > On 2026-May-09, Chao Li wrote: > >>> On May 9, 2026, at 01:47, Kirill Reshke <[email protected]> wrote: >>> >>> On Fri, 8 May 2026 at 09:22, Chao Li <[email protected]> wrote: > >>>> While testing UPDATE FOR PORTION OF, I started wondering whether >>>> REPACK supports temporal tables. In theory, it should, because >>>> temporal WITHOUT OVERLAPS indexes can be used as replica identity >>>> indexes. So I created a test script, repack_temporal.spec, which is >>>> included in the attached patch, and it failed. > > Nice find, thanks for testing. > >>>> I found that REPACK hard-codes BTEqualStrategyNumber when calling >>>> get_opfamily_member(). That seems wrong, because >>>> build_replindex_scan_key() uses IndexAmTranslateCompareType() to >>>> get the equality strategy for COMPARE_EQ. > > Makes sense. > > I think it would be a good idea to make identity_key_equal() not deform > all attributes, but instead only up to the last one it needs for the key > comparisons. >
That’s true. Please see v3. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/
v3-0001-Fix-REPACK-with-WITHOUT-OVERLAPS-replica-identity.patch
Description: Binary data
