Hi, I noticed that a comment in pgstat_assoc_relation() starts with "Else":
/* Else find or make the PgStat_TableStatus entry, and update link */ This seems to be a vestige from when this function was split out from pgstat_init_relation() by commit 5891c7a8ed8f, so I think we could simply remove the "Else". Regards, Yugo Nagata -- Yugo Nagata <[email protected]>
diff --git a/src/backend/utils/activity/pgstat_relation.c b/src/backend/utils/activity/pgstat_relation.c index b2ca28f83ba..04f2eb21d0b 100644 --- a/src/backend/utils/activity/pgstat_relation.c +++ b/src/backend/utils/activity/pgstat_relation.c @@ -134,7 +134,7 @@ pgstat_assoc_relation(Relation rel) Assert(rel->pgstat_enabled); Assert(rel->pgstat_info == NULL); - /* Else find or make the PgStat_TableStatus entry, and update link */ + /* find or make the PgStat_TableStatus entry, and update link */ rel->pgstat_info = pgstat_prep_relation_pending(RelationGetRelid(rel), rel->rd_rel->relisshared);
