> +       INJECTION_POINT("expand-vacuum-rel-skip-locked", NULL);

> Nitpick, but now that the injection point lives inside
> pgstat_report_skipped_vacuum_analyze, it should be named accordingly.

right. I renamed it to skipped-vacuum-analyze-before-entry-lock

> Nitpick, but now that the injection point lives inside
> pgstat_report_skipped_vacuum_analyze, it should be named accordingly.
>
> +        * This mirrors the approach used in pgstat_init_function_usage() for
> +        * functions.

Fair. I just removed this comment. On re-reading, it really did not
add more value.

Attached v9.

Thanks!

--
Sami

Attachment: v9-0001-Track-skipped-vacuum-and-analyze-activity-per-rel.patch
Description: Binary data

Attachment: v9-0002-Add-injection-point-test-for-vacuum-skip_locked-s.patch
Description: Binary data

Reply via email to