On Mon, May 18, 2026 at 2:15 AM Chao Li <[email protected]> wrote:
> > On May 18, 2026, at 05:45, Alexander Korotkov <[email protected]> wrote:
> >
> > Hi, Chao!
> >
> > On Thu, May 14, 2026 at 9:59 AM Chao Li <[email protected]> wrote:
> >> To make this patch easier to process, I split it into 4 commits:
> >>
> >> 0001 - Fixes the bound-overlap bug
> >> 0002 - Fix the incorrect HINT message for the DEFAULT case
> >> 0003 - Fix the incorrect description about combined bound in the SGML doc
> >> 0004 - Reject only-create-default-partition usage
> >
> > Thank you for your work.  I've revised the patchset.
> > 0002 - I've also fixed gramma of hints in other branches
> > 0004 - In the check_split_partition_not_same_bound(), calling
> > partition_bounds_create() and partition_bounds_equal() looks a bit
> > heavyweight.  It doesn't matter much performance-wise, but it feels
> > like start processing from scratch while we're on quite late stage
> > already.  I've replaced that with more lightweight check.  Also I
> > removed dealing with memory context.  This code implies small
> > non-repetitive memory allocations which only lives during DDL
> > operation, no need to wrap them with memory context as we don't do so
> > in other places.
> >
> > Any objections if I commit this?
> >
> > ------
> > Regards,
> > Alexander Korotkov
> > Supabase
>
> Hi Alexander,
>
> Thanks for the revisions. I think you may have missed the attachments, so I 
> cannot review the changes.

Sorry. Here it is.

------
Regards,
Alexander Korotkov
Supabase

Attachment: v3-0003-Clarify-SPLIT-PARTITION-bound-requirements-in-doc.patch
Description: Binary data

Attachment: v3-0001-Fix-SPLIT-PARTITION-range-bound-validation-with-D.patch
Description: Binary data

Attachment: v3-0002-Fix-SPLIT-PARTITION-hint-for-DEFAULT-partition-bo.patch
Description: Binary data

Attachment: v3-0004-Reject-degenerate-SPLIT-PARTITION-with-DEFAULT-pa.patch
Description: Binary data

Reply via email to