On Mon, May 25, 2026 at 5:00 PM Alexander Korotkov <[email protected]> wrote: > > On Sat, May 23, 2026 at 9:40 PM Xuneng Zhou <[email protected]> wrote: > >> > I agree with you. But do we actually need a > >> > wait_for_standby_and_slot_catchup() wrapper. I think we can call > >> > $node->wait_for_slot_catchup() directly and simplify the fix. Check > >> > the attached patch. > >> > > >> > >> The patch looks good to me. I agree that the wait_for_slot_catchup is > >> not needed and could be misleading. This change would make the exact > >> synchronization point and its intention clearer. The only price we > >> need to pay here is bringing back the polling. But it seems acceptable > >> since the cost was there in the pre-wait-for-lsn era. And thanks for > >> writing the great commit message! > > > > > > Sorry for copy-pasting the wrong function name. It should be > > wait_for_catchup(). > > Good, thank you. I'll push it if no objections.
While reading 019_replslot_limit.pl, Codex pointed out a few inconsistencies in the comments. I verified them and they look real. Would you mind doing a small cleanup as well? -- Regards, Xuneng Zhou HighGo Software Co., Ltd.
v2-0002-Clean-up-replslot-limit-test-comments.patch
Description: Binary data
