Hi Vignesh.
I had only one trivial review comment for v40-0001/0002 combined.
======
src/backend/commands/subscriptioncmds.c
1.
+ if (OidIsValid(subconflictlogrelid))
+ {
+ ObjectAddress object;
+ char *conflictrelname;
+
+ /* Drop any dependent conflict log table */
+ conflictrelname = get_rel_name(subconflictlogrelid);
That "Drop any..." comment doesn't have anything to do with the
statement that follows it. I think this comment belongs outside the
if.
e.g.
/* Drop any dependent conflict log table */
if (OidIsValid(subconflictlogrelid))
{
...
}
======
Kind Regards,
Peter Smith.
Fujitsu Australia
