Hi Henson, > Thanks for catching this. I applied the patch and the RPR regress passes > cleanly. I also re-ran it with debug_raw_expression_coverage_test turned > on (on an assert-enabled build), and the full regress is green as well. > > One observation while testing: the GUC catches missing case handlers > once the walker actually reaches a node, but it cannot flag a missing > WALK on its own -- if no caller drives the walker into a subtree, the > omission stays silent. So your inspection was the part that found the > gap; the GUC just confirms the patch closes it. With the patch in, RPR > raw subtrees are on the safety net for any future node-type additions.
Thanks for checking. > I'll include the patch in v48 as nocfbot-0015. My suggestion would > be to defer the fold until the jian-response patches (numbered from > 0016 onward, which I'll be sending shortly) have also gone through a > review round, so the whole bundle can land together in one pass. > Patch attached below for convenience. Sure. I will wait for your ready-to-go signal before creating the v48 pach set. Regards, -- Tatsuo Ishii SRA OSS K.K. English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sraoss.co.jp
