On Tuesday, May 26, 2026 11:32 PM Alvaro Herrera <[email protected]> wrote: > On 2026-May-25, Zhijie Hou (Fujitsu) wrote: > > > After listening to the REPACK talk at pgconf.dev this year, I > > understand that WAL accumulation during REPACK CONCURRENTLY is not > > intended behavior. I think we can consider fixing this in the current > > release. Attached is the rebased patch, with comments adjusted based on > Chao Li's comments. > > You're right, this is a thinko. I'll look at your patch hoping to get it > pushed > shortly. I wonder if we should add a TAP test to verify that WAL files are > actually removed? Sounds a bit excessive TBH, but maybe it isn't really.
I tried a bit, and the test complexity and speed (< 1s) appear to be within acceptable limits. I'm attaching 0002 as a reference test. 0001 remains unchanged. Best Regards, Hou zj
v3-0001-Allow-old-WAL-recycling-during-REPACK-CONCURRENTL.patch
Description: v3-0001-Allow-old-WAL-recycling-during-REPACK-CONCURRENTL.patch
v3-0002-Add-a-test-for-repack-concurrently.patch
Description: v3-0002-Add-a-test-for-repack-concurrently.patch
