Hi,

Thank you for looking into this!

On Thu, 28 May 2026 at 02:10, Zsolt Parragi <[email protected]> wrote:
>
> Hello!
>
> I didn't try the workflow on github yet, I only have a few comments
> based on the yaml file:
>
> +on:
> +  push:
> +    branches: [ "*" ]
> +
>
> Should this be "**", otherwise we ignore branches with a "/" in it?

You are right. I completely removed the 'branches:' part, now it
should match with every branch.


> +      SANITIZER_FLAGS: -fsanitize=address
>
> is this used anywhere? Seems like it's directly included into CFLAGS/LDFLAGS.

It wasn't used but I put it there for visibility since in Github
Actions you can't refer to other environment variables (Perhaps a
comment was needed for this). We don't use this now since all linux
tasks are merged in the v3 [1].

[1] 
https://postgr.es/m/CAN55FZ1-qiOWtQH5o6Q_7LJ7S3Ef_hfDE068uP0hGjB3gzwghg%40mail.gmail.com


-- 
Regards,
Nazir Bilal Yavuz
Microsoft


Reply via email to