On Fri, May 29, 2026, at 12:23 PM, Tom Lane wrote: > "Greg Burd" <[email protected]> writes: >> The zic.c hit is the one that bothers me. It's the same shape as des_init() >> -- >> byte-sized destination, scatter store via an indexing array -- and it's not >> exercised by `make check`, since zic runs at `make install` to compile the >> IANA >> tz data. > > "make check" certainly *will* run zic.c, while creating the temporary > installation. (Unless you use --with-system-tzdata, which I'm sure > most production builds do.) But our test suite touches only a very > tiny fraction of the tzdata files, so even if there's some > corruption in them we wouldn't necessarily notice it.
Apologies, you are correct about "make check". I think it's still bothersome that a bug can hide in plain sight, but I've not thought about how to supplement tests to fix that. Still waiting on LLVM/Clang to compile... > regards, tom lane best. -greg
