On Sun, May 31, 2026 at 10:57 AM Chao Li <[email protected]> wrote:

> While testing “file_fdw: Support multi-line HEADER option”, I noticed a small 
> issue.

Thanks for reporting this!

> The fix is straightforward. Since we already have the “header_specified" 
> variable to indicate whether the option is present, we can check 
> “header_specified" instead.

Overall, the patch LGTM. Could you add COPY test cases like the following:

copy t to '/tmp/test.json' (format json, header 0);
copy t to '/tmp/test.bin' (format binary, header 0);

-- 
Best regards,
Shinya Kato
NTT OSS Center


Reply via email to