solai v <[email protected]> writes: Hello,
> > [...] One thing I noticed is that the function currently returns > SETOF text, producing multiple DDL statements such as CREATE > PUBLICATION followed by ALTER PUBLICATION ... OWNER TO .... I wanted > to check whether this is the intended long-term API design, as most > existing pg_get_* functions return a single text value. Yes this is by design, it's documented that they will return the OWNER[1] unless that publications doesn't intend to have an OWNER in the DDL. > I also noticed > that publication options are emitted as quoted values, for example: > > publish='insert, update' > publish_generated_columns='none' > publish_via_partition_root='false' > > Would it make sense to emit enum-like and boolean values in their > native SQL form instead, such as: > > publish = 'insert, update' > publish_generated_columns = none > publish_via_partition_root = false Yes, this was already handled by Peter Smith[1] email Regards! [1] https://www.postgresql.org/docs/19/functions-info.html#FUNCTIONS-GET-OBJECT-DDL [2] https://www.postgresql.org/message-id/CAHut%2BPvyd3vN_LV8ppyX6Vu7pKdBhC5M3_zHN7gdJCvz1%3DkKHQ%40mail.gmail.com -- Jonathan Gonzalez V. EDB https://www.enterprisedb.com
