Dear Chao, > Yes, this patch rejects negative values at CREATE/ALTER SUBSCRIPTION time, > so in theory the if (MySubscription->maxretention <= 0) change is not strictly > necessary. I made that change for a few reasons (from strong do weak):
I personal preference is to use Assert() for detecting cannot-happen case, but it's not very strong opinion. Let's see how others say. Best regards, Hayato Kuroda FUJITSU LIMITED
