> On Jun 18, 2026, at 10:44, Tatsuo Ishii <[email protected]> wrote:
>
> Hi,
>
>> Thanks for working on this!
>>
>> I have a couple of comments.
>>
>> When executing a non-existent function with IGNORE NULLS, for example,
>>
>> SELECT no_such_func() IGNORE NULLS;
>>
>> previously we got:
>>
>> ERROR: function no_such_func() does not exist
>>
>> but now we get:
>>
>> ERROR: only window functions accept RESPECT/IGNORE NULLS
>>
>> Isn't the previous error more helpful in this case? It makes me wonder
>> whether the IGNORE NULLS check is being performed too early. Perhaps
>> it would be better to move the check to other place.
>
> Agreed. BTW, if the check is moved there, it might be better to
> change the error message according to the surroundings. The pattern is
> "... specified, but %s is not a ..."
>
> errmsg("OVER specified, but %s is not a window function nor an aggregate
> function",
>
> So the message could be changed to something like:
>
> errmsg("RESPECT/IGNORE NULLS is specified, but %s is not a window function"),
>
Yes, this is also my only comment for the patch.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
