> On Jun 18, 2026, at 14:27, David Rowley <[email protected]> wrote:
>
> On Thu, 18 Jun 2026 at 17:56, Chao Li <[email protected]> wrote:
>> I don’t know why you added these commented SQL statements, I guess you have
>> your reason. The problem is, in the 3 SELECTs, gtest21c should probably be
>> gtest21d.
>
> This relates to the "-- keep these tests aligned with
> generated_stored.sql" at the top of the file.
>
> I mentioned in [1];
>> I pushed the patch to add the new test after modifying it to also
>> include the change in the generated_stored test, but with it commented
>> out. This is the method that 83ea6c540 introduced.
>
> and this is meant to follow the same pattern.
Thanks for the explanation.
>
> I've attached a version with the commented table names fixed. Thanks
> for looking.
>
> David
>
> [1]
> https://postgr.es/m/CAApHDvrJBXEhet4=es_whbkdv5pcv5ogcajosmjexeafqfm...@mail.gmail.com
> <fix_jit_deform_for_virtual_generated_cols_v3.patch>
This version feels all set.
I also tried to build and run tests, all passed.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
