At Tue, 23 Jun 2026 13:03:21 +0900, Michael Paquier <[email protected]> wrote in > On Mon, Jun 22, 2026 at 09:47:06PM -0500, Baji Shaik wrote: > > Attached v2 with two patches: > > > > 0001 - Adds check_io_worker_gucs() with parameterized GUC names (%s) > > 0002 - Adjusts check_av_worker_gucs() to use the same format > > > > Both now produce the same translatable errmsg pattern: > > "\"%s\" (%d) should be less than or equal to \"%s\" (%d)" > > That looks sensible here.
I have two minor comments. As Michael suggested, using placeholders for the GUC names could make similar messages easier to share in the future, which may also help reduce the number of translation strings. I wouldn't consider it necessary to adjust the existing autovacuum_max_workers/autovacuum_worker_slots message as part of this patch, though. Also, "Re-check" in the second call-site comment feels a bit vague to me, since the previous call is quite far away. Perhaps both call-site comments could simply describe checking the relevant GUC values, one at startup and the other after a configuration reload. Regards, -- Kyotaro Horiguchi NTT Open Source Software Center
