At Mon, 22 Jun 2026 18:10:53 +0530, Akshay Joshi <[email protected]> wrote in > The v9 patch is ready for review.
I have not looked closely at the DDL generation logic itself, but I have a few comments on how pg_get_table_ddl handles its options. Since pg_get_table_ddl_internal() appears to copy these values into TableDdlContext almost immediately, I wonder whether TableDdlContext could be initialized by the caller instead. Using positional boolean arguments is probably fine when there are only a handful of options, but with around fifteen of them the current approach seems somewhat error-prone. It might also be clearer to initialize the default values first, and then override only the fields corresponding to explicitly specified options, rather than folding the default handling and option lookup into the same expression. Regards, -- Kyotaro Horiguchi NTT Open Source Software Center
