Hi jian, Thanks -- this is a clean improvement, no objections. Honestly this part of the parser is an area where you read it better than I do, so I'm glad to defer to you here. Quick notes inline.
> The above comments can be deleted, ParseRPRNavCall, ParseFuncOrColumn > already have lots of comments. > Also the error check and its message are quite intuitive in ParseRPRNavCall. Agreed. > So, I tended to use coerce_to_target_type. Agreed. > ParseRPRNavCall ending can be simplified because coerce_to_target_type > can handle the same data type. > Therefore, `if (offtype != INT8OID)` is not necessary. Agreed. > Drop the extra parentheses around ereport() argument lists, fewer > parentheses are always better for new code. Agreed. Tatsuo, this one looks good to take whenever you like. Best, Henson
