From 7f939667057e3d62ee98e08480493465691b51e1 Mon Sep 17 00:00:00 2001 From: Vignesh C Date: Fri, 19 Jun 2026 19:14:27 +0530 Subject: [PATCH v3] Include sequences in publications created by pg_createsubscriber pg_createsubscriber creates a publication on the publisher to establish logical replication between the original primary and the converted subscriber. Currently, the publication is created with FOR ALL TABLES, which ensures that table data changes are replicated during the upgrade process. However, sequence state is not replicated as part of this workflow. Recent additions to logical replication introduced support for publishing all sequences and synchronizing sequence state through subscription refresh. By creating publications with FOR ALL TABLES, ALL SEQUENCES, pg_createsubscriber can take advantage of these capabilities and allow sequence state to be synchronized before the upgraded node is promoted. This change modifies pg_createsubscriber to include ALL SEQUENCES in the publication it creates. Administrators can then run ALTER SUBSCRIPTION ... REFRESH SEQUENCES after the upgrade to synchronize sequence state, ensuring a more complete and reliable upgrade workflow. --- doc/src/sgml/ref/pg_createsubscriber.sgml | 43 +++++++++++++------ src/bin/pg_basebackup/pg_createsubscriber.c | 4 +- .../t/040_pg_createsubscriber.pl | 8 ++++ 3 files changed, 39 insertions(+), 16 deletions(-) diff --git a/doc/src/sgml/ref/pg_createsubscriber.sgml b/doc/src/sgml/ref/pg_createsubscriber.sgml index 3b3038d1891..eddac27af9f 100644 --- a/doc/src/sgml/ref/pg_createsubscriber.sgml +++ b/doc/src/sgml/ref/pg_createsubscriber.sgml @@ -49,10 +49,12 @@ PostgreSQL documentation pg_createsubscriber creates a new logical replica from a physical standby server. All tables in the specified - database are included in the logical - replication setup. A pair of - publication and subscription objects are created for each database. It - must be run at the target server. + database are included in the + logical replication setup. The + publications created by pg_createsubscriber also + include all sequences, allowing their state to be synchronized after the + upgrade. A pair of publication and subscription objects are created for each + database. It must be run at the target server. @@ -61,7 +63,9 @@ PostgreSQL documentation replication setup and pg_createsubscriber is how the data synchronization is done. pg_createsubscriber does not copy the initial table data. It does only the synchronization phase, - which ensures each table is brought up to a synchronized state. + which ensures each table is brought up to a synchronized state. The + subscriptions are configured to include sequences, but sequence values are + not synchronized automatically. @@ -75,7 +79,12 @@ PostgreSQL documentation synchronization. For details, see the CREATE SUBSCRIPTION copy_data option. + + + To synchronize sequence values, run + + ALTER SUBSCRIPTION ... REFRESH SEQUENCES. @@ -275,10 +284,10 @@ PostgreSQL documentation publications: - The FOR ALL TABLES publications established for this - subscriber are always dropped; specifying this object type causes all - other publications replicated from the source server to be dropped as - well. + The FOR ALL TABLES, ALL SEQUENCES publications + established for this subscriber are always dropped; specifying this + object type causes all other publications replicated from the source + server to be dropped as well. @@ -323,7 +332,8 @@ PostgreSQL documentation If a specified publication already exists on the publisher, it is reused. It is useful to partially replicate the database if the specified publication includes a list of tables. If the publication does not exist, - it is automatically created with FOR ALL TABLES. Use + it is automatically created with + FOR ALL TABLES, ALL SEQUENCES. Use option to preview which publications will be reused and which will be created. @@ -532,10 +542,15 @@ PostgreSQL documentation Create a publication and replication slot for each specified database on - the source server. Each publication is created using FOR ALL - TABLES. If the option - is not specified, the publication has the following name pattern: + the source server. If the --publication option is not specified, + pg_createsubscriber creates a publication + using + FOR ALL TABLES and + + ALL SEQUENCES. Otherwise, it uses the + user-specified publication, which includes the objects defined by that + publication. If the option is not + specified, the publication has the following name pattern: pg_createsubscriber_%u_%x (parameter: database oid, random int). If the option is not specified, the diff --git a/src/bin/pg_basebackup/pg_createsubscriber.c b/src/bin/pg_basebackup/pg_createsubscriber.c index 4d705778454..ec18faf50eb 100644 --- a/src/bin/pg_basebackup/pg_createsubscriber.c +++ b/src/bin/pg_basebackup/pg_createsubscriber.c @@ -1788,7 +1788,7 @@ wait_for_end_recovery(const char *conninfo, const struct CreateSubscriberOptions } /* - * Create a publication that includes all tables in the database. + * Create a publication that includes all tables and sequences in the database. */ static void create_publication(PGconn *conn, struct LogicalRepInfo *dbinfo) @@ -1840,7 +1840,7 @@ create_publication(PGconn *conn, struct LogicalRepInfo *dbinfo) pg_log_info("creating publication \"%s\" in database \"%s\"", dbinfo->pubname, dbinfo->dbname); - appendPQExpBuffer(str, "CREATE PUBLICATION %s FOR ALL TABLES", + appendPQExpBuffer(str, "CREATE PUBLICATION %s FOR ALL TABLES, ALL SEQUENCES", ipubname_esc); pg_log_debug("command is: %s", str->data); diff --git a/src/bin/pg_basebackup/t/040_pg_createsubscriber.pl b/src/bin/pg_basebackup/t/040_pg_createsubscriber.pl index 9252d1c3c5c..044f202cb35 100644 --- a/src/bin/pg_basebackup/t/040_pg_createsubscriber.pl +++ b/src/bin/pg_basebackup/t/040_pg_createsubscriber.pl @@ -503,6 +503,14 @@ is($result, qq(0), 'the physical replication slot used as primary_slot_name has been removed' ); +# Verify that the publication is configured to publish all tables and +# all sequences. +$result = $node_p->safe_psql($db2, + "SELECT puballtables, puballsequences FROM pg_publication"); +is( $result, qq(t|t), + "publication is created with both all-tables and all-sequences enabled" +); + # Insert rows on P $node_p->safe_psql($db1, "INSERT INTO tbl1 VALUES('third row')"); $node_p->safe_psql($db2, "INSERT INTO tbl2 VALUES('row 1')"); -- 2.53.0