Hi, On Thu, Jun 25, 2026 at 1:13 PM Tom Lane <[email protected]> wrote: > > Sami Imseih <[email protected]> writes: > > e3a87b499 states "There's no intention to make wholesale > > changes of existing ereport calls ..." > > > Why do it for pg_stat_statements only when there are a bunch > > of other places? > > I think we should flat out reject this patch. It makes no functional > improvement while creating a merge hazard for future back-patches. > That hazard might not be very large for just changing these few > spots, but any more-aggressive attempt at changing existing ereports' > style will certainly result in pain. > > As e3a87b499 said, there was no plan to change existing code and > I think that decision should still stand.
+1 to what's said above. The merge burden is real (recently it took me more than 30 minutes just to create patches for back-branches even though most of the code remains the same in the function being changed). IMHO, it's not worth the cycles. -- Bharath Rupireddy Amazon Web Services: https://aws.amazon.com
