On Fri, Jun 26, 2026 at 1:11 PM Bertrand Drouvot <[email protected]> wrote: > On Fri, Jun 26, 2026 at 08:21:50AM +0900, Amit Langote wrote: > > On Fri, Jun 26, 2026 at 12:05 AM Bertrand Drouvot > > <[email protected]> wrote: > > > Just one nit: > > > > > > + Assert for development builds and, since > > > + * the transaction is already committed by now and FK checks may > > > have been > > > + * skipped, also warn in production builds. > > > > > > s/development builds/assert-enabled builds/? That looks more common and " > > > development builds" would be introduced by this patch. > > > > I grepped, and while the word "development" isn't rare in the tree, > > none of the uses are "development builds" as a build type. > > Right. > > > "assert-enabled" is the established term for that, so I've switched to > > it in v2. > > Thanks! LGTM.
Thanks, pushed. -- Thanks, Amit Langote
