Hi, On Mon, Jul 6, 2026 at 1:31 PM Shlok Kyal <[email protected]> wrote: > > On Thu, 2 Jul 2026 at 11:59, Shlok Kyal <[email protected]> wrote: > > > > > > > > The attached v6 version patch has the changes for the same. > > > > > Hi Vignesh, > > > > I reviewed the v6 patch and tested it manually for some scenarios. It > > is working fine. > > And the patch mostly looks good to me. > > > > A minor comment: > > pg_perltidy run is required on the 040_pg_createsubscriber.pl patch. > > > I ran pg_perltidy on the 040_pg_createsubscriber.pl file and attached > the updated v7 version of patch. >
I have one small comment from the latest patch and here it is: +# Verify that the publication is configured to publish all tables and +# all sequences. This sounds a bit ambiguous. Do we actually publish sequences in the same sense as table changes? Other comments/docs describe sequences as being included in a publication for synchronization, rather than being published like tables. Maybe this should say something like: "Verify that the publication is configured to include all tables and all sequences." -- With Regards, Ashutosh Sharma.
