On 20.04.26 01:52, David Rowley wrote:
On Mon, 20 Apr 2026 at 07:22, Greg Burd <[email protected]> wrote:
I applied, tested, and reviewed these changes. Thanks for doing this, only a
few small things jumped out.
Many thanks. I took all of those suggestions.
SELECT test_bms_offset_members('(b 1)', -2147483648);
I made that one use member 0 instead of 1. That'll mean "new_highest"
goes to INT_MIN rather than INT_MIN + 1.
In the function test_random_offset_operations(), the variable seed is
declared as type uint64, then assigned from GetCurrentTimestamp() or
PG_GETARG_INT64(), both of which return int64, then it is passed to
pg_prng_seed(), which takes uint64, and then it is printed using
INT64_FORMAT. Maybe this could be a bit more consistent?
