> Attached is an updated patch. That's OK now, the patch applying is without any errors. I have no more remarks.
>Пятница, 5 октября 2018, 13:04 +03:00 от Peter Eisentraut ><peter.eisentr...@2ndquadrant.com>: > >On 03/10/2018 13:51, Andrey Klychkov wrote: >> 1. Patch was applied without any errors except a part related to >> documentation: >> error: patch failed: doc/src/sgml/ref/alter_index.sgml:50 >> error: doc/src/sgml/ref/alter_index.sgml: patch does not apply > >Attached is an updated patch. > >> 2. The code has been compiled successfully, configured by: >> # ./configure CFLAGS="-O0" --enable-debug --enable-cassert >> --enable-depend --without-zlib > >Not sure why you use -O0 here. It's not a good idea for development, >because it might miss interesting warnings. > >> 7. Code style: >> +RenameRelationInternal(Oid myrelid, const char *newrelname, bool >> is_internal, bool is_index) >> This line is longer than 80 chars. > >pgindent leaves this line alone. > >-- >Peter Eisentraut http://www.2ndQuadrant.com/ >PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Regards, Andrey Klychkov
